[breaking] Updated gRPC Platform API #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
refactor_platofrm_grpc_api
branch
4 times, most recently
from
52f5dc3 to
94413ed
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2357 +/- ##
==========================================
+ Coverage 63.55% 63.85% +0.30%
==========================================
Files 205 206 +1
Lines 19289 19422 +133
==========================================
+ Hits 12259 12402 +143
+ Misses 5936 5925 -11
- Partials 1094 1095 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
force-pushed
the
refactor_platofrm_grpc_api
branch
4 times, most recently
from
9e18ebe to
ffef84b
Compare
cmaglie
force-pushed
the
refactor_platofrm_grpc_api
branch
from
ffef84b to
b37a73c
Compare
cmaglie
commented
Oct 16, 2023
alessio-perugini
force-pushed
the
refactor_platofrm_grpc_api
branch
3 times, most recently
from
17371e8 to
a8c5dff
Compare
alessio-perugini
added
topic: code
alessio-perugini
requested review from
umbynos and
MatteoPologruto
and removed request for
umbynos
umbynos
approved these changes
Oct 17, 2023
alessio-perugini
force-pushed
the
refactor_platofrm_grpc_api
branch
from
a8c5dff to
ad08831
Compare
alessio-perugini
force-pushed
the
refactor_platofrm_grpc_api
branch
from
0d4798a to
8528612
Compare
This was referenced Oct 24, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
A refactoring/rationalization of the gRPC
PlatformAPI.This PR is draft to explore the soundness of the proposed changes.
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Yes.
Other information